netdev - Re: [PATCH v2 05/13] ftgmac100: Cleanup speed/duplex tracking and fix duplex config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170405145803.GG13449@lunn.ch>
Date:   Wed, 5 Apr 2017 16:58:03 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2 05/13] ftgmac100: Cleanup speed/duplex tracking and
 fix duplex config

On Wed, Apr 05, 2017 at 12:28:45PM +1000, Benjamin Herrenschmidt wrote:
> Keep track of both the current speed and duplex settings
> instead of only speed and properly apply the duplex setting
> to the HW.
> 
> This reworks the adjust_link() function to also avoid trying
> to reconfigure the HW when there is no link and to display
> the link state to the user.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew