netdev - Re: [PATCH net-next 1/1] skbuff: Extend gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170405.063426.330966962521980983.davem@davemloft.net>
Date:   Wed, 05 Apr 2017 06:34:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     steffen.klassert@...unet.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/1] skbuff: Extend gso_type to unsigned int.

From: Steffen Klassert <steffen.klassert@...unet.com>
Date: Mon, 3 Apr 2017 10:15:52 +0200

> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index 9f78109..8796b93 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -257,7 +257,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask,
>  
>  	/* make sure we initialize shinfo sequentially */
>  	shinfo = skb_shinfo(skb);
> -	memset(shinfo, 0, offsetof(struct skb_shared_info, dataref));
> +	memset(shinfo, 0, offsetof(struct skb_shared_info, _unused));
>  	atomic_set(&shinfo->dataref, 1);
>  	kmemcheck_annotate_variable(shinfo->destructor_arg);
>  

There is another memset() that needs this conversion in __build_skb().