netdev - Re: [PATCH 3/4] net: dsa: LAN9303: add I2C managed mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5f2bc76-c563-d990-f5b0-79b8856d0950@gmail.com>
Date:   Thu, 6 Apr 2017 06:52:06 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Juergen Borleis <jbe@...gutronix.de>, Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de, vivien.didelot@...oirfairelinux.com,
        davem@...emloft.net
Subject: Re: [PATCH 3/4] net: dsa: LAN9303: add I2C managed mode support


On 04/06/2017 06:46 AM, Juergen Borleis wrote:
>>> +		phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_LOW>;
>>> +		phy-reset-duration = <200>;
>>> +
>>> +		dsa,member = <0 0>;
>>> +
>>> +		ports {
>>> +			#address-cells = <1>;
>>> +			#size-cells = <0>;
>>> +
>>> +			port@0 { /* RMII fixed link to master */
>>> +				reg = <0>;
>>> +				label = "cpu";
>>> +				ethernet = <&master>;
>>> +				max-speed = <100>;
>>
>> max-speed does not do anything i think, since there is no adjust_link
>> function.

Since port 0 is the CPU port, we expect to find a fixed PHY for it, so
yes, this won't do much because fixed-link already appropriately limits
the speed.
-- 
Florian