netdev - Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Fix warning with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170406140431.GA17713@lunn.ch>
Date:   Thu, 6 Apr 2017 16:04:31 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Fix warning with
 CONFIG_OF=n

On Thu, Apr 06, 2017 at 06:47:35AM -0700, Florian Fainelli wrote:
> When CONFIG_OF=n, we will see the following warning:
> 
> drivers/net/dsa/mv88e6xxx/chip.c:2834:34: warning: 'mv88e6xxx_mdio_external_match' defined but not used [-Wunused-const-variable=]
>  static const struct of_device_id mv88e6xxx_mdio_external_match[] = {
>                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  drivers/net/dsa/mv88e6xxx/chip.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index 44ba8cff5631..64cbc4c04907 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -2831,11 +2831,13 @@ static int mv88e6xxx_mdio_register(struct mv88e6xxx_chip *chip,
>  	return 0;
>  }
>  
> +#ifdef CONFIG_OF
>  static const struct of_device_id mv88e6xxx_mdio_external_match[] = {
>  	{ .compatible = "marvell,mv88e6xxx-mdio-external",
>  	  .data = (void *)true },
>  	{ },
>  };
> +#endif

Hi Florian

Maybe a better fix is to make the stub of of_match_node() an inline
function, so its parameters are used. That will fix this warning
everywhere in the kernel, not just in this driver.

	   Andrew