netdev - Re: [PATCH net 1/1] net: tcp: Don't increase the TCP_MIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQy=5GXBQzvDtbxQp-0ndJ1KphcxkY42mHsDPST0+sMGw2A@mail.gmail.com>
Date:   Thu, 6 Apr 2017 10:08:20 -0400
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Gao Feng <gfree.wind@...mail.com>
Cc:     David Miller <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        James Morris <jmorris@...ei.org>,
        Patrick McHardy <kaber@...sh.net>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net 1/1] net: tcp: Don't increase the TCP_MIB_OUTRSTS when
 fail to transmit RST

On Thu, Apr 6, 2017 at 10:05 AM, Gao Feng <gfree.wind@...mail.com> wrote:
> If so, we should increase the TCP_MIB_OUTRSTS too when fail to alloc skb.
> When machine is overloaded and mem is exhausted, it may fail to alloc skb.

Moving the increment of TCP_MIB_OUTRSTS to the top of
tcp_send_active_reset() sounds fine to me.

neal