netdev - Re: [PATCH] net: ipv4: fix multipath RTM_GETROUTE behavior when iif is given

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170406.121943.2291300582139303531.davem@davemloft.net>
Date:   Thu, 06 Apr 2017 12:19:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fl@...1.de
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: ipv4: fix multipath RTM_GETROUTE behavior when
 iif is given

From: Florian Larysch <fl@...1.de>
Date: Mon,  3 Apr 2017 16:46:09 +0200

> inet_rtm_getroute synthesizes a skeletal ICMP skb, which is passed to
> ip_route_input when iif is given. If a multipath route is present for
> the designated destination, ip_multipath_icmp_hash ends up being called,
> which uses the source/destination addresses within the skb to calculate
> a hash. However, those are not set in the synthetic skb, causing it to
> return an arbitrary and incorrect result.
> 
> Instead, use UDP, which gets no such special treatment.
> 
> Signed-off-by: Florian Larysch <fl@...1.de>

Applied and queued up for -stable.

Please submit the net-next variant you mentioned, thank you.