netdev - Re: [Patch net] net_sched: check noop_qdisc before qdisc_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170406.122945.2116775205917467295.davem@davemloft.net>
Date:   Thu, 06 Apr 2017 12:29:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, dvyukov@...gle.com, edumazet@...gle.com,
        jkosina@...e.cz
Subject: Re: [Patch net] net_sched: check noop_qdisc before qdisc_hash_add()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Tue,  4 Apr 2017 18:51:30 -0700

> Dmitry reported a crash when injecting faults in
> attach_one_default_qdisc() and dev->qdisc is still
> a noop_disc, the check before qdisc_hash_add() fails
> to catch it because it tests NULL. We should test
> against noop_qdisc since it is the default qdisc
> at this point.
> 
> Fixes: 59cc1f61f09c ("net: sched: convert qdisc linked list to hashtable")
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Cc: Jiri Kosina <jkosina@...e.cz>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable.