netdev - Re: [PATCH net] nfp: fix potential use after free on xdp prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170405.184708.708302621362328912.davem@davemloft.net>
Date:   Wed, 05 Apr 2017 18:47:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, kubakici@...pl, oss-drivers@...ronome.com
Subject: Re: [PATCH net] nfp: fix potential use after free on xdp prog

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Tue,  4 Apr 2017 15:56:55 -0700

> We should unregister the net_device first, before we give back
> our reference on xdp_prog.  Otherwise xdp_prog may be freed
> before .ndo_stop() disabled the datapath.  Found by code inspection.
> 
> Fixes: ecd63a0217d5 ("nfp: add XDP support in the driver")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Simon Horman <simon.horman@...ronome.com>

Applied, thanks.

> ---
> Just a heads up - this will cause a merge conflict since nn->netdev
> member got moved to nn->dp.netdev in net-next.

Ok, thanks for the heads up.