netdev - Re: tcpprobe display format for snd_nxt and snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170406174531.4fca96b0@plumbers-lap.home.lan>
Date:   Thu, 6 Apr 2017 17:45:31 -0400
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     hiren panchasara <hiren@...ugglingcoder.info>
Cc:     netdev@...r.kernel.org
Subject: Re: tcpprobe display format for snd_nxt and snd_una

On Wed, 5 Apr 2017 12:40:09 -0700
hiren panchasara <hiren@...ugglingcoder.info> wrote:

> (New to linux and first-time poster so please guide me if needed.)
>  
> Upon using tcpprobe I realized that it prints snd_nxt and snd_una as hex
> which makes it harder to read and compare with tcpdump for example.
>  
> Not sure if that is intentional. If not, a simple patch like this would
> print them as decimals.
>  
> [PATCH] Display snd_nxt and snd_una as decimals for better
>  readability.
>  
> ---
>  net/ipv4/tcp_probe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  
> diff --git a/net/ipv4/tcp_probe.c b/net/ipv4/tcp_probe.c
> index f6c50af..a8e66c1 100644
> --- a/net/ipv4/tcp_probe.c
> +++ b/net/ipv4/tcp_probe.c
> @@ -191,7 +191,7 @@ static int tcpprobe_sprint(char *tbuf, int n)
>                 = ktime_to_timespec64(ktime_sub(p->tstamp, tcp_probe.start));
>  
>         return scnprintf(tbuf, n,
> -                       "%lu.%09lu %pISpc %pISpc %d %#x %#x %u %u %u %u %u\n",
> +                       "%lu.%09lu %pISpc %pISpc %d %u %u %u %u %u %u %u\n",
>                         (unsigned long)ts.tv_sec,
>                         (unsigned long)ts.tv_nsec,
>                         &p->src, &p->dst, p->length, p->snd_nxt, p->snd_una,
> --
>  
> Let me know if I am missing something obvious.

The output of tcpprobe is intended for consumption by programs.
Changing the output format would be considered a kernel ABI breakage which
is something Linux tries not to do. Therefore I would prefer it
not be changed. Sorry if this is inconvenient for you but breaking other
users scripts would be a bigger problem.

Also, your patch email is not formatted with subject [RFC] or [PATCH]
and is missing signed-off-by.