netdev - Re: [PATCH net] bridge: netlink: register netdevice before executing changelink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170407144416.625462ec@plumbers-lap.home.lan>
Date:   Fri, 7 Apr 2017 14:44:16 -0400
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        idosch@...lanox.com, netdev@...r.kernel.org, davem@...emloft.net,
        bridge@...ts.linux-foundation.org, mlxsw@...lanox.com,
        peter@...nota.eu, cera@...a.cz
Subject: Re: [PATCH net] bridge: netlink: register netdevice before
 executing changelink

On Fri, 7 Apr 2017 21:16:49 +0300
Ido Schimmel <idosch@...sch.org> wrote:

> On Fri, Apr 07, 2017 at 01:37:53PM -0400, Stephen Hemminger wrote:
> > Fix it right now. The patch you propose is too half baked.  
> 
> Given this patch needs to be back ported to three different stable
> kernels I tried to keep the amount of changes to a minimum while fixing
> the bug.
> 
> I'll work on the ndo_uninit() patch and submit it. Then people can
> decide which course of action they're more comfortable with.

I don't want enterprise distros to ship without error reporting.
At a minimum just return correct errno and leave bridge in stuck/broken state.