netdev - Re: [PATCH 02/12] ftgmac100: Move ftgmac100_hard_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 08 Apr 2017 09:14:11 +1000
From:   Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH 02/12] ftgmac100: Move ftgmac100_hard_start_xmit() around

On Fri, 2017-04-07 at 13:09 +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 4/7/2017 6:30 AM, Benjamin Herrenschmidt wrote:
> 
> > Move it below ftgmac100_xmit() and the rest of the tx path
> > 
> > No code change.
> > 
> > Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> > ---
> >  drivers/net/ethernet/faraday/ftgmac100.c | 59 ++++++++++++++++--
> > --------------
> >  1 file changed, 30 insertions(+), 29 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
> > b/drivers/net/ethernet/faraday/ftgmac100.c
> > index f4b719214..3966c7a 100644
> > --- a/drivers/net/ethernet/faraday/ftgmac100.c
> > +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> > @@ -63,6 +63,7 @@ struct ftgmac100 {
> >  	u32 rxdes0_edorr_mask;
> > 
> >  	/* Tx ring */
> > +	struct sk_buff *tx_skbs[TX_QUEUE_ENTRIES];
> 
>     "No code change", really?

Patch splitting accident, thanks for pointing it out. I'll fix it up in
the next round.

> 
> >  	unsigned int tx_clean_pointer;
> >  	unsigned int tx_pointer;
> >  	unsigned int tx_pending;
> 
> [...]
> 
> MBR, Sergei