netdev - Re: [PATCH 2/4] mm: introduce memalloc_noreclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <092401d2af71$fc320ef0$f4962cd0$@alibaba-inc.com>
Date:   Fri, 07 Apr 2017 15:38:43 +0800
From:   "Hillf Danton" <hillf.zj@...baba-inc.com>
To:     "'Vlastimil Babka'" <vbabka@...e.cz>,
        "'Andrew Morton'" <akpm@...ux-foundation.org>
Cc:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        "'Michal Hocko'" <mhocko@...nel.org>,
        "'Mel Gorman'" <mgorman@...hsingularity.net>,
        "'Johannes Weiner'" <hannes@...xchg.org>,
        <linux-block@...r.kernel.org>, <nbd-general@...ts.sourceforge.net>,
        <open-iscsi@...glegroups.com>, <linux-scsi@...r.kernel.org>,
        <netdev@...r.kernel.org>, "'Michal Hocko'" <mhocko@...e.com>
Subject: Re: [PATCH 2/4] mm: introduce memalloc_noreclaim_{save,restore}


On April 05, 2017 3:47 PM Vlastimil Babka wrote: 
> 
> The previous patch has shown that simply setting and clearing PF_MEMALLOC in
> current->flags can result in wrongly clearing a pre-existing PF_MEMALLOC flag
> and potentially lead to recursive reclaim. Let's introduce helpers that support
> proper nesting by saving the previous stat of the flag, similar to the existing
> memalloc_noio_* and memalloc_nofs_* helpers. Convert existing setting/clearing
> of PF_MEMALLOC within mm to the new helpers.
> 
> There are no known issues with the converted code, but the change makes it more
> robust.
> 
> Suggested-by: Michal Hocko <mhocko@...e.com>
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>
> ---

Acked-by: Hillf Danton <hillf.zj@...baba-inc.com>