netdev - Re: [PATCH net-next 0/1 v2] skbuff: Extend gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170408.123234.1062158742988397943.davem@davemloft.net>
Date:   Sat, 08 Apr 2017 12:32:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     steffen.klassert@...unet.com, netdev@...r.kernel.org,
        edumazet@...gle.com, alexander.duyck@...il.com
Subject: Re: [PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned
 int.

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 08 Apr 2017 11:55:32 -0700

> On Sat, 2017-04-08 at 20:36 +0200, Steffen Klassert wrote:
>> All available gso_type flags are currently in use, so
>> extend gso_type from 'unsigned short' to 'unsigned int'
>> to be able to add further flags.
>> 
>> We reorder the struct skb_shared_info to use
>> two bytes of the four byte hole before dataref.
>> All fields before dataref are cleared, i.e.
>> four bytes more than before the change.
>> 
>> The remaining two byte hole is moved to the
>> beginning of the structure, this protects us
>> from immediate overwites on out of bound writes
>> to the sk_buff head.
> 
>> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
...
> This looks much better, thanks Steffen.
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks everyone.