netdev - Re: [PATCH net-next 1/7] ibmvnic: Add is_up flag to avoid transmits when driver is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170409.143024.691078252187673837.davem@davemloft.net>
Date:   Sun, 09 Apr 2017 14:30:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     nfont@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, tlfalcon@...ux.vnet.ibm.com,
        jallen@...ux.vnet.ibm.com, brking@...ux.vnet.ibm.com,
        muvic@...ux.vnet.ibm.com
Subject: Re: [PATCH net-next 1/7] ibmvnic: Add is_up flag to avoid
 transmits when driver is down

From: Nathan Fontenot <nfont@...ux.vnet.ibm.com>
Date: Sun, 09 Apr 2017 00:11:32 -0400

> From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
> 
> There are brief windows when handling events such as failover where we
> could attempt to transmit packets between receiving the transport event
> notification and handling the reset in the workqueue.
> 
> This patch introduces an is_up flag so we can avoid transmit attempts at
> these times.
> 
> Signed-off-by: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
> Signed-off-by: Nathan Fontenot <nfont@...ux.vnet.ibm.com>

Simply stop the netdev queue when the device is in this state.
The kernel will stop queueing packets to the device if you do
that.

Please do not add unnecessary extra state and logic for this,
it doesn't appear to be necessary.

Thank you.