netdev - Re: [PATCH net-next v3 1/2] bpf: remove struct bpf_prog_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58EBAC23.2040404@iogearbox.net>
Date:   Mon, 10 Apr 2017 18:00:35 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Johannes Berg <johannes@...solutions.net>, netdev@...r.kernel.org
CC:     alexei.starovoitov@...il.com,
        Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH net-next v3 1/2] bpf: remove struct bpf_prog_type_list

On 04/10/2017 02:44 PM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@...el.com>
>
> There's no need to have struct bpf_prog_type_list since
> it just contains a list_head, the type, and the ops
> pointer. Since the types are densely packed and not
> actually dynamically registered, it's much easier and
> smaller to have an array of type->ops pointer. Also
> initialize this array statically to remove code needed
> to initialize it.
>
> In order to save duplicating the list, move it to a new
> header file and include it in the places needing it.
>
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

Looks awesome!

Acked-by: Daniel Borkmann <daniel@...earbox.net>