netdev - Re: [PATCH net v3 0/2] bridge: Fix kernel oops during bridge creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170410160601.67120d94@plumbers-lap.home.lan>
Date:   Mon, 10 Apr 2017 16:06:01 -0400
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        bridge@...ts.linux-foundation.org, mlxsw@...lanox.com,
        peter@...nota.eu, nikolay@...ulusnetworks.com,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net v3 0/2] bridge: Fix kernel oops during bridge
 creation

On Mon, 10 Apr 2017 14:59:26 +0300
idosch@...sch.org wrote:

> From: Ido Schimmel <idosch@...lanox.com>
> 
> First patch adds a missing ndo_uninit() in the bridge driver, which is a
> prerequisite for the second patch that actually fixes the oops.
> 
> Please consider both patches for 4.4.y, 4.9.y and 4.10.y
> 
> Ido Schimmel (2):
>   bridge: implement missing ndo_uninit()
>   bridge: netlink: register netdevice before executing changelink
> 
>  net/bridge/br_device.c    | 20 +++++++++++---------
>  net/bridge/br_if.c        |  1 -
>  net/bridge/br_multicast.c |  7 +++++--
>  net/bridge/br_netlink.c   |  7 +++++--
>  net/bridge/br_private.h   |  5 +++++
>  5 files changed, 26 insertions(+), 14 deletions(-)
> 

Looks good, thanks for following through on this.

Reviewed-by: Stephen Hemminger <stephen@...workplumber.org>