netdev - Re: [PATCH net-next v2] can: initial support for network namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a15f2ec-4cf4-1d15-f727-1dd666f4cb59@hartkopp.net>
Date:   Mon, 10 Apr 2017 14:15:08 +0200
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     Mario Kicherer <dev@...herer.org>, netdev@...r.kernel.org,
        linux-can@...r.kernel.org, mkl@...gutronix.de
Subject: Re: [PATCH net-next v2] can: initial support for network namespaces

Hello Mario,

On 04/10/2017 09:51 AM, Mario Kicherer wrote:

>> You didn't include the statistics here:
>>
>> +       struct s_stats *can_stats;      /* packet statistics */
>> +       struct s_pstats *can_pstats;    /* receive list statistics */
>>
>> which need to be per-net too, right?
>
> I was not sure how this information is used - e.g., maybe just as debug
> information that the system is working. Hence, I just left them as they
> were.

Ok. Completed that now ;-)

>> You do a kzalloc(sizeof(struct dev_rcv_lists), GFP_KERNEL) in
>> can_pernet_init().
>>
>> Doesn't it need a kfree(net->can.can_rx_alldev_list) then??
>
> Yes, I missed this. Thanks!

I consistently did not remove my new structs too ;-)
Will send a v2 of my 'completion' patch for a review.

> Unfortunately, I don't have access to my CAN hardware right now, hence
> I cannot test a corresponding patch at the moment. :/

Using virtual CANs should be ok for testing.

Best regards,
Oliver