netdev - Re: [PATCH net-next v4 2/2] bpf: remove struct bpf_map_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170411144316.GB10662@ast-mbp.thefacebook.com>
Date:   Tue, 11 Apr 2017 07:43:17 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     netdev@...r.kernel.org, daniel@...earbox.net,
        Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH net-next v4 2/2] bpf: remove struct bpf_map_type_list

On Tue, Apr 11, 2017 at 03:34:58PM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@...el.com>
> 
> There's no need to have struct bpf_map_type_list since
> it just contains a list_head, the type, and the ops
> pointer. Since the types are densely packed and not
> actually dynamically registered, it's much easier and
> smaller to have an array of type->ops pointer. Also
> initialize this array statically to remove code needed
> to initialize it.
> 
> In order to save duplicating the list, move it to the
> types header file added by the previous patch and
> include it in the same fashion.
> 
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> ---
> v4: add ifdef on CONFIG_PERF_EVENTS for stack_map_ops

I'm ok if you keep my ack after minor changes like this.
Acked-by: Alexei Starovoitov <ast@...nel.org>

saves me typing another email and spamming everyone once more..