netdev - Re: [PATCH net-next v2] bpf: pass sk to helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170411181439.GA31880@ast-mbp.thefacebook.com>
Date:   Tue, 11 Apr 2017 11:14:41 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     netdev@...r.kernel.org, ast@...com, daniel@...earbox.net,
        davem@...emloft.net, fengc@...gle.com, lorenzo@...gle.com,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next v2] bpf: pass sk to helper functions

On Tue, Apr 11, 2017 at 02:08:08PM -0400, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> BPF helper functions access socket fields through skb->sk. This is not
> set in ingress cgroup and socket filters. The association is only made
> in skb_set_owner_r once the filter has accepted the packet. Sk is
> available as socket lookup has taken place.
> 
> Temporarily set skb->sk to sk in these cases.
> 
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Acked-by: Alexei Starovoitov <ast@...nel.org>