netdev - Re: [PATCH] net: stmmac: add drop transmit status feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170411.145305.907770601077151355.davem@davemloft.net>
Date:   Tue, 11 Apr 2017 14:53:05 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Joao.Pinto@...opsys.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: add drop transmit status feature

From: Joao Pinto <Joao.Pinto@...opsys.com>
Date: Tue, 11 Apr 2017 15:44:10 +0100

> +static void dwmac4_enable_tx_drop(struct mac_device_info *hw)
> +{
> +	void __iomem *ioaddr = hw->pcsr;
> +	u32 value = readl(ioaddr + MTL_OPERATION_MODE);
> +
> +	value &= ~MTL_OPERATION_DTXSTS;
> +	value |= MTL_OPERATION_DTXSTS;

I think the mask is unnecessary, just simply set the bit.