netdev - Re: [PATCH net-next v5 3/5] netlink: allow sending extended ACK with cookie on success

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1492005271.2855.6.camel@sipsolutions.net>
Date:   Wed, 12 Apr 2017 15:54:31 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        pablo@...filter.org, Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Benc <jbenc@...hat.com>,
        David Ahern <dsa@...ulusnetworks.com>
Subject: Re: [PATCH net-next v5 3/5] netlink: allow sending extended ACK
 with cookie on success


> > 	} else {
> > 		flags |= NLM_F_CAPPED;
> > +
> > +		if (nlk->flags & NETLINK_F_EXT_ACK &&
> > +		    extack && extack->cookie_len)
> > +			tlvlen += nla_total_size(extack-
> > >cookie_len);
> > 	}
> > 
> 
> Now I see why you have "if (tlvlen)" where you have it :)

Ah, you had me wondering with that comment ... Yeah, I'd been
developing this by adding patches and then rebasing, so the fact that
this could've been elsewhere to start with never crossed my mind.

johannes