netdev - Re: [PATCH net-next v5 1/5] netlink: extended ACK reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170412.113056.1269483192753304111.davem@davemloft.net>
Date:   Wed, 12 Apr 2017 11:30:56 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     johannes@...solutions.net
Cc:     dsa@...ulusnetworks.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, pablo@...filter.org, jhs@...atatu.com,
        jbenc@...hat.com, jiri@...nulli.us
Subject: Re: [PATCH net-next v5 1/5] netlink: extended ACK reporting

From: Johannes Berg <johannes@...solutions.net>
Date: Wed, 12 Apr 2017 17:21:43 +0200

> On Wed, 2017-04-12 at 09:06 -0600, David Ahern wrote:
>> 
>> There was a discussion about side effects of adding strings (bloat,
>> internationalization). Should ATTR_MSG be removed until that is
>> ironed out? Leaving it in suggests it is ok to start adding strings.
> 
> I really do want the strings; this is why I named the struct member
> "_msg" and added the NL_SET_ERR_MSG() macro, that will easily allow
> both making the strings optional with Kconfig (bloat) and collecting
> them into a separate data section (translation).

Yep, this is a long range plan.