netdev - Re: [PATCH net-next v1 1/1] L2TP device MTU setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGeBGG6zrCVTBnpphXc94p=FjWRbVXhH7=zfY8o73TQsRReR_A@mail.gmail.com>
Date:   Wed, 12 Apr 2017 13:38:42 -0700
From:   R Parameswaran <parameswaran.r7@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        kleptog@...na.org, James Chapman <jchapman@...alix.com>,
        Nachi Prachanda <nprachan@...cade.com>,
        Robert Shearman <rshearma@...cade.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Sven-Thorsten Dietrich <sdietric@...cade.com>,
        Chas Williams III <ciwillia@...cade.com>,
        Luca Boccassi <lboccass@...cade.com>,
        Derek Fawcus <dfawcus@...cade.com>,
        Bill Hong <bhong@...cade.com>,
        Jan Blunck <jblunck@...cade.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v1 1/1] L2TP device MTU setup - tunnel socket
 needs a lock

Hi Dave,

Please see inline:

On Wed, Apr 12, 2017 at 7:13 AM, David Miller <davem@...emloft.net> wrote:
> From: "R. Parameswaran" <parameswaran.r7@...il.com>
> Date: Tue, 11 Apr 2017 20:14:37 -0700 (PDT)
>
>>
>> The MTU overhead calculation in L2TP device set-up
>> merged via commit b784e7ebfce8cfb16c6f95e14e8532d0768ab7ff
>> needs to be adjusted to lock the tunnel socket while
>> referencing the sub-data structures to derive the
>> socket's IP overhead.
>
> This is missing a proper signoff.
>
> The subject line also needs to be fixed "[PATCH net-next] l2tp: " as explained
> by Guillaume.
>

Thanks, I will re-spin with these corrections by tonight PT.

regards,

Ramkumar
> Thanks.