netdev - Re: [PATCH next] bonding: handle link transition from FAIL to UP correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170413.134937.410754519019663582.davem@davemloft.net>
Date:   Thu, 13 Apr 2017 13:49:37 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mahesh@...dewar.net
Cc:     j.vosburgh@...il.com, andy@...yhouse.net, vfalico@...il.com,
        nikolay@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org,
        maheshb@...gle.com
Subject: Re: [PATCH next] bonding: handle link transition from FAIL to UP
 correctly

From: Mahesh Bandewar <mahesh@...dewar.net>
Date: Tue, 11 Apr 2017 22:36:00 -0700

> From: Mahesh Bandewar <maheshb@...gle.com>
> 
> When link transitions from LINK_FAIL to LINK_UP, the commit phase is
> not called. This leads to an erroneous state causing slave-link state to
> get stuck in "going down" state while its speed and duplex are perfectly
> fine. This issue is a side-effect of splitting link-set into propose and
> commit phases introduced by de77ecd4ef02 ("bonding: improve link-status
> update in mii-monitoring")
> 
> This patch fixes these issues by calling commit phase whenever link
> state change is proposed.
> 
> Fixes: de77ecd4ef02 ("bonding: improve link-status update in mii-monitoring")
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>

Applied, thanks.