netdev - Re: [PATCH net-next 4/8] net/ncsi: Add debugging infrastructurre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170413051112.GA28206@gwshan>
Date:   Thu, 13 Apr 2017 15:11:12 +1000
From:   Gavin Shan <gwshan@...ux.vnet.ibm.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Gavin Shan <gwshan@...ux.vnet.ibm.com>, netdev@...r.kernel.org,
        davem@...emloft.net
Subject: Re: [PATCH net-next 4/8] net/ncsi: Add debugging infrastructurre

On Wed, Apr 12, 2017 at 09:28:26PM -0700, Joe Perches wrote:
>On Thu, 2017-04-13 at 12:46 +1000, Gavin Shan wrote:
>> This creates procfs directories as NCSI debugging infrastructure.
>> With the patch applied, We will see below procfs directories. Every
>> NCSI package and channel has one corresponding directory. Other than
>> presenting the NCSI topology, No real function has been achieved
>> through these procfs directories so far.
>
>/proc is meant to be stable.
>
>Why not use debugfs?
>

Joe, thanks for the comment. I think debugfs makes more sense than
procfs in this case. I will use it in next respin. The directory
structure won't change, meaning /sys/kernel/debug/ncsi/ will be
created.

>>      /proc/ncsi/eth0
>>      /proc/ncsi/eth0/p0
>>      /proc/ncsi/eth0/p0/c0
>>      /proc/ncsi/eth0/p0/c1
>

Thanks,
Gavin