[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201704131514.fLLOlm8n%fengguang.wu@intel.com>
Date: Thu, 13 Apr 2017 15:28:31 +0800
From: kbuild test robot <lkp@...el.com>
To: Cong Wang <xiyou.wangcong@...il.com>
Cc: kbuild-all@...org, netdev@...r.kernel.org, roid@...lanox.com,
Cong Wang <xiyou.wangcong@...il.com>,
Daniel Borkmann <daniel@...earbox.net>,
John Fastabend <john.fastabend@...il.com>
Subject: Re: [Patch net-next v2] net_sched: move the empty tp check from
->destroy() to ->delete()
Hi Cong,
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Cong-Wang/net_sched-move-the-empty-tp-check-from-destroy-to-delete/20170413-145318
config: x86_64-randconfig-x004-201715 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
net/sched/cls_matchall.c: In function 'mall_destroy':
>> net/sched/cls_matchall.c:99:10: warning: 'return' with a value, in function returning void
return true;
^~~~
net/sched/cls_matchall.c:93:13: note: declared here
static void mall_destroy(struct tcf_proto *tp)
^~~~~~~~~~~~
net/sched/cls_matchall.c:105:9: warning: 'return' with a value, in function returning void
return true;
^~~~
net/sched/cls_matchall.c:93:13: note: declared here
static void mall_destroy(struct tcf_proto *tp)
^~~~~~~~~~~~
vim +/return +99 net/sched/cls_matchall.c
b87f7936 Yotam Gigi 2016-07-21 83 offload.type = TC_SETUP_MATCHALL;
b87f7936 Yotam Gigi 2016-07-21 84 offload.cls_mall = &mall_offload;
b87f7936 Yotam Gigi 2016-07-21 85 offload.cls_mall->command = TC_CLSMATCHALL_DESTROY;
b87f7936 Yotam Gigi 2016-07-21 86 offload.cls_mall->exts = NULL;
b87f7936 Yotam Gigi 2016-07-21 87 offload.cls_mall->cookie = cookie;
b87f7936 Yotam Gigi 2016-07-21 88
b87f7936 Yotam Gigi 2016-07-21 89 dev->netdev_ops->ndo_setup_tc(dev, tp->q->handle, tp->protocol,
b87f7936 Yotam Gigi 2016-07-21 90 &offload);
b87f7936 Yotam Gigi 2016-07-21 91 }
b87f7936 Yotam Gigi 2016-07-21 92
a762f5c9 Cong Wang 2017-04-12 93 static void mall_destroy(struct tcf_proto *tp)
bf3994d2 Jiri Pirko 2016-07-21 94 {
bf3994d2 Jiri Pirko 2016-07-21 95 struct cls_mall_head *head = rtnl_dereference(tp->root);
b87f7936 Yotam Gigi 2016-07-21 96 struct net_device *dev = tp->q->dev_queue->dev;
bf3994d2 Jiri Pirko 2016-07-21 97
fd62d9f5 Yotam Gigi 2017-01-31 98 if (!head)
fd62d9f5 Yotam Gigi 2017-01-31 @99 return true;
bf3994d2 Jiri Pirko 2016-07-21 100
fd62d9f5 Yotam Gigi 2017-01-31 101 if (tc_should_offload(dev, tp, head->flags))
fd62d9f5 Yotam Gigi 2017-01-31 102 mall_destroy_hw_filter(tp, head, (unsigned long) head);
b87f7936 Yotam Gigi 2016-07-21 103
fd62d9f5 Yotam Gigi 2017-01-31 104 call_rcu(&head->rcu, mall_destroy_rcu);
bf3994d2 Jiri Pirko 2016-07-21 105 return true;
bf3994d2 Jiri Pirko 2016-07-21 106 }
bf3994d2 Jiri Pirko 2016-07-21 107
:::::: The code at line 99 was first introduced by commit
:::::: fd62d9f5c575f0792f150109f1fd24a0d4b3f854 net/sched: matchall: Fix configuration race
:::::: TO: Yotam Gigi <yotamg@...lanox.com>
:::::: CC: David S. Miller <davem@...emloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (28417 bytes)
Powered by blists - more mailing lists