netdev - Re: [PATCH v3] smsc95xx: Add comments to the registers definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170413081027.bmt447cwz7jlltwk@SMX-2>
Date:   Thu, 13 Apr 2017 10:10:27 +0200
From:   martin@...terwald.eu
To:     Woojung.Huh@...rochip.com
Cc:     davem@...emloft.net, andrew@...n.ch, steve.glendinning@...well.net,
        UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v3] smsc95xx: Add comments to the registers definition

On 12/04/17 22:10, Woojung.Huh@...rochip.com wrote:
> Sorry forgetting that you are referring RPi which uses LAN9514.
> Because these LEDs' GPIO can vary per chip (LAN9500, 9514..), it would be better
> not putting GPIO number. LAN9500 are GPIO 10/9/8 as described.
> 
> > While we are here, could you indicate the meaning of the bit 2 of
> > HW_CFG register (it's named HW_CFG_PSEL_)? It's the only bit I didn't
> > succeed to comment because I didn't find it in the datasheet.
> > I will then add it to the patch!
> It indicates internal & external phy, PSEL means PHY Select.
> You can find at LAN9500 doc in http://ww1.microchip.com/downloads/en/DeviceDoc/00001875C.pdf.
> 
> > I'm also wondering what the meaning of STRAP_STATUS is. I could also
> > comment it if you or Steve can provide the information.
> It is marked as reserved in above LAN9500 manual.
> You may guess from configuration straps in the manual and define names.
> 
> Woojung

Thank you for your help Woojung!

Martin