netdev - Re: [PATCH net-next 1/1 v3] drivers: net: rmnet: Initial implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170414145936.40962060@xeon-e3>
Date:   Fri, 14 Apr 2017 14:59:36 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Cc:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
        davem@...emloft.net, fengguang.wu@...el.com, dcbw@...hat.com
Subject: Re: [PATCH net-next 1/1 v3] drivers: net: rmnet: Initial
 implementation

On Fri, 14 Apr 2017 15:57:22 -0600
Subash Abhinov Kasiviswanathan <subashab@...eaurora.org> wrote:

> >> +				rmnet_kfree_skb
> >> +				(skb,
> >> +				 RMNET_STATS_SKBFREE_INGRESS_NOT_EXPECT_MAPD);  
> > 
> > very odd formatting. Please fix.
> >   
> Checkpatch complains if it is over 80 chars in a line, so I had to do 
> this.
> I'll change to a single line.

Either ignore checkpatch, it is only a dumb script; or better yet refactor
the code so it isn't indented so much.