netdev - Re: [PATCH v2 net-next 5/8] net/ncsi: Dump NCSI packet statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170413185042.0e69cb71@cakuba.lan>
Date:   Thu, 13 Apr 2017 18:50:42 -0700
From:   Jakub Kicinski <kubakici@...pl>
To:     Gavin Shan <gwshan@...ux.vnet.ibm.com>
Cc:     netdev@...r.kernel.org, joe@...ches.com, davem@...emloft.net
Subject: Re: [PATCH v2 net-next 5/8] net/ncsi: Dump NCSI packet statistics

Hi!

On Thu, 13 Apr 2017 17:48:18 +1000, Gavin Shan wrote:
> This creates /sys/kernel/debug/ncsi/<eth0>/stats to dump the NCSI
> packets sent and received over all packages and channels. It's useful
> to diagnose NCSI problems, especially when NCSI packages and channels
> aren't probed properly. The statistics can be gained from debugfs file
> as below:
> 
>  # cat /sys/kernel/debug/ncsi/eth0/stats
> 
>  CMD          OK       TIMEOUT  ERROR
>  =======================================
>  CIS          32       29       0
>  SP           10       7        0
>  DP           17       14       0
>  EC           1        0        0
>  ECNT         1        0        0
>  AE           1        0        0
>  GLS          11       0        0
>  SMA          1        0        0
>  EBF          1        0        0
>  GVI          2        0        0
>  GC           2        0        0
> 
>  RSP          OK       TIMEOUT  ERROR
>  =======================================
>  CIS          3        0        0
>  SP           3        0        0
>  DP           2        0        1
>  EC           1        0        0
>  ECNT         1        0        0
>  AE           1        0        0
>  GLS          11       0        0
>  SMA          1        0        0
>  EBF          1        0        0
>  GVI          0        0        2
>  GC           2        0        0
> 
>  AEN          OK       TIMEOUT  ERROR
>  =======================================
> 
> Signed-off-by: Gavin Shan <gwshan@...ux.vnet.ibm.com>

I'm not familiar with NC-SI but these look like some standard stats.
Would it make sense to provide a proper netlink API for them?

[...]
> +#ifdef CONFIG_NET_NCSI_DEBUG
> +		ndp->stats.aen[h->type][NCSI_PKT_STAT_ERROR]++;
> +#endif

In any case, did you consider creating a macro or inline helper to
limit the number of #ifdefs?