netdev - Re: [PATCH iproute2 net-next 1/3] ip: add ip sr command to control SR-IPv6 internal structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170414154531.7ef9df18@xeon-e3>
Date:   Fri, 14 Apr 2017 15:45:31 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     David Lebrun <david.lebrun@...ouvain.be>
Cc:     <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2 net-next 1/3] ip: add ip sr command to control
 SR-IPv6 internal structures

On Fri, 14 Apr 2017 14:36:21 +0200
David Lebrun <david.lebrun@...ouvain.be> wrote:

> +static struct {
> +	int cmd;
Why not unsigned? you only assign positive values
> +	struct in6_addr addr;
> +	__u32 keyid;
> +	char *pass;
Why not const char *? or do you free the value on exit?
> +	__u8 alg_id;
> +} opts;
> +