netdev - Re: ipv6 udp early demux breaks udp_l3mdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170415.094810.1393827754237126920.davem@davemloft.net>
Date:   Sat, 15 Apr 2017 09:48:10 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dsa@...ulusnetworks.com
Cc:     subashab@...eaurora.org, netdev@...r.kernel.org,
        rshearma@...cade.com
Subject: Re: ipv6 udp early demux breaks udp_l3mdev_accept=0

From: David Ahern <dsa@...ulusnetworks.com>
Date: Fri, 14 Apr 2017 18:42:14 -0600

> On 4/14/17 6:38 PM, Subash Abhinov Kasiviswanathan wrote:
>> On 2017-04-14 16:23, David Ahern wrote:
>>> Subash:
>>>
>>> My understanding of early demux is that it should only match connected
>>> sockets (src/sport + dst/dport are all set). The ipv6 udp early demux
>>> code added in 5425077d73e0c is doing a generic socket lookup which does
>>> not require an exact match and accordingly breaks udp_l3mdev_accept=0.
>>> Please fix.
>>>
>>> David
>> 
>> Hi David
>> 
>> Would it be possible to disable udp_early_demux for your case temporarily.
>> I'll look into this.
>> 
> 
> It should be fixed for 4.12. Basically, __udp6_lib_demux_lookup needs to
> be more like __udp4_lib_demux_lookup

Agreed.