netdev - Re: [patch iproute2/net-next repost] devlink: Add support for pipeline debug (dpipe)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170415.095705.1787032921503797059.davem@davemloft.net>
Date:   Sat, 15 Apr 2017 09:57:05 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     stephen@...workplumber.org, netdev@...r.kernel.org,
        arkadis@...lanox.com, idosch@...lanox.com, mlxsw@...lanox.com,
        jhs@...atatu.com, ivecera@...hat.com, roopa@...ulusnetworks.com,
        f.fainelli@...il.com, vivien.didelot@...oirfairelinux.com,
        john.fastabend@...il.com, andrew@...n.ch,
        simon.horman@...ronome.com
Subject: Re: [patch iproute2/net-next repost] devlink: Add support for
 pipeline debug (dpipe)

From: Jiri Pirko <jiri@...nulli.us>
Date: Sat, 15 Apr 2017 10:59:03 +0200

> Sat, Apr 15, 2017 at 01:01:38AM CEST, stephen@...workplumber.org wrote:
>>On Thu, 13 Apr 2017 11:30:27 +0200
>>Jiri Pirko <jiri@...nulli.us> wrote:
>>
>>> We actually took this code from teamdctl (at least it was an influence).
>>> Devlink style is so much different in every aspect from the rest of the
>>> iproute2 suite. And I did it on purpose, because it is much nicer and
>>> easier to read. I would like to continue on this and don't do things in
>>> the was the existing tools do. I don't see any problem with that.
>>
>>No. That is road to ruin. Every package is free to use what ever style
>>it wants. But don't crossover please.
> 
> So we are stuck with some ugly way just because some other util does it?
> Well, in devlink I wrote lot of things differently, nicer. For example
> cmdline parsing. Why is it a "road to ruin"?

I agree with Jiri, if he wants to stylize devlink a certain way that
makes sense for devlink information, that is perfectly fine and does
not impact the way the rest of iproute2's output appears to the user
at all.