[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170416102227.2356400e@xeon-e3>
Date: Sun, 16 Apr 2017 10:22:27 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: David Lebrun <david.lebrun@...ouvain.be>
Cc: <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2 net-next v2 1/3] ip: add ip sr command to
control SR-IPv6 internal structures
Overall, this looks fine and applied.
I had to add seg6.h to include/linux since it was not there.
> + switch (alg_id) {
> + case SEG6_HMAC_ALGO_SHA1:
> + algstr = "sha1";
> + break;
> + case SEG6_HMAC_ALGO_SHA256:
> + algstr = "sha256";
> + break;
> + default:
> + algstr = "<unknown>";
> + }
You might want to consider having a table of HMAC algorithms so that get and set match.
It seems likely that new values will come.
Powered by blists - more mailing lists