netdev - Re: [PATCH] net: natsemi: ns83820: add checks for dma mapping error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170417.151743.1779341653983811894.davem@davemloft.net>
Date:   Mon, 17 Apr 2017 15:17:43 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     khoroshilov@...ras.ru
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH] net: natsemi: ns83820: add checks for dma mapping error

From: Alexey Khoroshilov <khoroshilov@...ras.ru>
Date: Sat, 15 Apr 2017 01:50:50 +0300

> @@ -1136,6 +1141,10 @@ static netdev_tx_t ns83820_hard_start_xmit(struct sk_buff *skb,
>  	if (nr_frags)
>  		len -= skb->data_len;
>  	buf = pci_map_single(dev->pci_dev, skb->data, len, PCI_DMA_TODEVICE);
> +	if (pci_dma_mapping_error(dev->pci_dev, buf)) {
> +		dev_kfree_skb_any(skb);
> +		return NETDEV_TX_OK;
> +	}
>  
>  	first_desc = dev->tx_descs + (free_idx * DESC_SIZE);
>  

You need to also add this check for the skb_map_dma_frag() calls below
this line, and therefore you'll need to add unwind on such a failure.