netdev - Re: [PATCH v2 net-next 4/8] net/ncsi: Add debugging infrastructurre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170417232214.GA3569@gwshan>
Date:   Tue, 18 Apr 2017 09:22:14 +1000
From:   Gavin Shan <gwshan@...ux.vnet.ibm.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Gavin Shan <gwshan@...ux.vnet.ibm.com>, netdev@...r.kernel.org,
        davem@...emloft.net
Subject: Re: [PATCH v2 net-next 4/8] net/ncsi: Add debugging infrastructurre

On Thu, Apr 13, 2017 at 03:41:46AM -0700, Joe Perches wrote:
>On Thu, 2017-04-13 at 17:48 +1000, Gavin Shan wrote:
>> This creates debugfs directories as NCSI debugging infrastructure.
>> With the patch applied, We will see below debugfs directories. Every
>> NCSI package and channel has one corresponding directory. Other than
>> presenting the NCSI topology, No real function has been achieved
>> through these debugfs directories so far.
>> 
>>      /sys/kernel/debug/ncsi/eth0
>>      /sys/kernel/debug/ncsi/eth0/p0
>>      /sys/kernel/debug/ncsi/eth0/p0/c0
>>      /sys/kernel/debug/ncsi/eth0/p0/c1
>
>[]
>
>> diff --git a/net/ncsi/ncsi-debug.c b/net/ncsi/ncsi-debug.c
>[]
>> +int ncsi_dev_init_debug(struct ncsi_dev_priv *ndp)
>> +{
>> +	if (WARN_ON_ONCE(ndp->dentry))
>> +		return 0;
>> +
>> +	if (!ncsi_dentry) {
>> +		ncsi_dentry = debugfs_create_dir("ncsi", NULL);
>> +		if (!ncsi_dentry) {
>> +			pr_warn("NCSI: Cannot create /sys/kernel/debug/ncsi\n");
>> +			return -ENOENT;
>
>debugfs does not have a fixed path.
>
>Most error messages for this just use something like
>	pr_<level>("Failed to create debugfs directory '%s'\n", foo)
>And most failures don't emit any error message at all.
>

Thanks, Joe. I will correct in next respin.

Thanks,
Gavin