netdev - Re: Case for reusing netlink PADs WAS(Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170418.112935.686195434402345158.davem@davemloft.net>
Date:   Tue, 18 Apr 2017 11:29:35 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     jhs@...atatu.com, eric.dumazet@...il.com, netdev@...r.kernel.org,
        xiyou.wangcong@...il.com
Subject: Re: Case for reusing netlink PADs WAS(Re: [PATCH net-next 1/1] net
 sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

From: Jiri Pirko <jiri@...nulli.us>
Date: Tue, 18 Apr 2017 15:16:56 +0200

> It's ugly. Plus user may pass garbage in pads from current apps.

%100 agreed.

> Why you don't just use new attributes? I don't get it.  I still
> don't understand why people feel need to do struct style message
> passing in TLV-designed Netlink interface...

Also agreed, I don't see why it's such a big deal.

Once we define a structure, let's set it in stone and don't try to
modify it's layout or meaning.  It is the only safe approach.

We made netlink have attributes exactly for this reason.