netdev - Re: Marvell phy errata origins?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170418140450.GB13724@lunn.ch>
Date:   Tue, 18 Apr 2017 16:04:50 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Daniel Walker <danielwa@...co.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Andy Fleming <afleming@...escale.com>,
        Harini Katakam <harini.katakam@...inx.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        HEMANT RAMDASI <hramdasi@...co.com>,
        "Julius Hemanth Pitti -X (jpitti - MONTA VISTA SOFTWARE INC at Cisco)" 
        <jpitti@...co.com>
Subject: Re: Marvell phy errata origins?

On Tue, Apr 18, 2017 at 06:16:33AM -0700, Daniel Walker wrote:
> 
> Hi,
> 
> Cisco is using a Marvell 88E1112 phy. It seems to be fairly similar
> to the 88E1111 which Harini added a fix for.

Hi Daniel

If you look at Marvell reference drive, DSDT, they are actually quite
different. Different virtual cable tester, different downshift
configuration, different packet generator, different loopback. I would
say they are different generations of PHY.

> In Harini's commit
> message for ,
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/phy/marvell.c?id=3ec0a0f10ceb
> 
> "This function has a sequence accessing Page 5 and Register 31, both
> of which are not defined or reserved for this PHY"
> 
> For the 88E1112 we see that these are "Factory Test Modes" which the
> contents of are not documented. They aren't really "not defied", and
> aren't really "reserved" .. Marvell support claims they don't
> support these drivers, and Freescale seems to be adding these
> drivers, and the line we are looking at.
> 
> We had some issues with our PHY which were corrected with the same
> patch Harini used but modified for the M88E1112. We're trying to get
> to the bottom of where this code came from and what it was suppose
> to be doing.

I tried to find this errata fix in the Marvell reference code. And
failed to find it. But it is "Vendor Crap" code, hard to find anything
in it.

My guess is, this errata just applies to one model of PHY, maybe even
one revision of one model of a PHY. The hard bit is figuring out what
actually needs it. Do you have access to Marvell datasheets?

Otherwise, go back to what appears to be the first commit for this
driver:

commit 00db8189d984d6c51226dafbbe4a667ce9b7d5da
Author: Andy Fleming <afleming@...escale.com>
Date:   Sat Jul 30 19:31:23 2005 -0400

    This patch adds a PHY Abstraction Layer to the Linux Kernel, enabling
    ethernet drivers to remain as ignorant as is reasonable of the connected
    PHY's design and operation details.
    
    Signed-off-by: Andy Fleming <afleming@...escale.com>
    Signed-off-by: Jeff Garzik <jgarzik@...ox.com>

It seems a reasonable guess that any PHY added after this commit does
not need the errata.

    Andrew