netdev - RE: [PATCH] gso: Validate assumption of frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM4PR0501MB1940128F2938037CC0D04065DB180@AM4PR0501MB1940.eurprd05.prod.outlook.com>
Date:   Wed, 19 Apr 2017 11:17:22 +0000
From:   Ilan Tayari <ilant@...lanox.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "alexander.h.duyck@...el.com" <alexander.h.duyck@...el.com>,
        "eric.dumazet@...il.com" <eric.dumazet@...il.com>,
        "steffen.klassert@...unet.com" <steffen.klassert@...unet.com>,
        Boris Pismenny <borisp@...lanox.com>,
        Ilya Lesokhin <ilyal@...lanox.com>
Subject: RE: [PATCH] gso: Validate assumption of frag_list segementation

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> 
> > From: Ilan Tayari <ilant@...lanox.com>
> >
> > Commit 07b26c9454a2 ("gso: Support partial splitting at the frag_list
> > pointer") assumes that all SKBs in a frag_list (except maybe the last
> > one) contain the same amount of GSO payload.
> >
> > This assumption is not always correct, resulting in the following
> > warning message in the log:
> >     skb_segment: too many frags
> >
> > For example, mlx5 driver in Striding RQ mode creates some RX SKBs with
> > one frag, and some with 2 frags.
> > After GRO, the frag_list SKBs end up having different amounts of
> payload.
> > If this frag_list SKB is then forwarded, the aforementioned assumption
> > is violated.
> >
> > Validate the assumption, and fall back to software GSO if it not true.
> >
> > Fixes: 07b26c9454a2 ("gso: Support partial splitting at the frag_list
> > pointer")
> > Signed-off-by: Ilan Tayari <ilant@...lanox.com>
> > Signed-off-by: Ilya Lesokhin <ilyal@...lanox.com>
> > ---
> 
> Your commit message mentions a fixes tag which make this change seem
> relevant for 'net', but your patch depends upon things in 'net-next'
> and therefore only applies there.
> 
> I've added this change to net-next, but I want an explanation of why this
> change is not targettting 'net' if it seems to fix a problem there.
> 
> Thanks.

Sorry, my mistake.

This fix does belong to 'net', but this patch needs a modification to be
applied there.

I will send a patch for 'net' as well.

Thanks