netdev - Re: [PATCH net] ipv4: Avoid caching dsts when lookup skipped nh oif check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec8e470e-73d0-b357-4f65-a4f7e020db7f@brocade.com>
Date:   Thu, 20 Apr 2017 15:39:43 +0100
From:   Robert Shearman <rshearma@...cade.com>
To:     David Ahern <dsa@...ulusnetworks.com>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH net] ipv4: Avoid caching dsts when lookup skipped nh oif
 check

On 20/04/17 15:21, David Ahern wrote:
> On 4/20/17 6:58 AM, Robert Shearman wrote:
>> David reported that doing the following:
>>
>>     ip li add red type vrf table 10
>>     ip link set dev eth1 vrf red
>>     ip addr add 127.0.0.1/8 dev red
>>     ip link set dev eth1 up
>>     ip li set red up
>>     ping -c1 -w1 -I red 127.0.0.1
>>     ip li del red
>>
>> results in a hang with this message:
>>
>>     unregister_netdevice: waiting for red to become free. Usage count = 1
>
> I think you misunderstood my comment. The above works fine today. There
> is no bug with refcnts.
>
> It breaks with your patches wanting to use a VRF device with the main
> table (254).

That doesn't seem to match with my experience. I can reproduce this on 
the net tree with the listed commands and the behaviour matches what I 
see in the code.

Thanks,
Rob