netdev - Re: [PATCH net v2] net/mlx5e: Fix race in mlx5e_sw_stats and mlx5e_vport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170420165011.66lx7gm5e3bk7k67@kafai-mba.dhcp.thefacebook.com>
Date:   Thu, 20 Apr 2017 09:50:11 -0700
From:   Martin KaFai Lau <kafai@...com>
To:     Eric Dumazet <eric.dumazet@...il.com>
CC:     Saeed Mahameed <saeedm@....mellanox.co.il>,
        Gal Pressman <galp@...lanox.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH net v2] net/mlx5e: Fix race in mlx5e_sw_stats and
 mlx5e_vport_stats

On Thu, Apr 20, 2017 at 08:00:41AM -0700, Eric Dumazet wrote:
> On Thu, 2017-04-20 at 07:15 -0700, Martin KaFai Lau wrote:
>
> > A follow-up patch approach by Gal will be nice.
>
> Note that I had a similar issue on mlx4.
>
> Stats are cleared/reset at open time, but in an asynchronous way.
>
> Using a bonding device ( and fix in
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=142c6594acbcc32391af9c15f8cd65c6c177698f ) worked around the problem.
We also drop the X->0 delta now but does not drop the 0->Y delta.