netdev - Re: [PATCH net] selftests/net: Fixes psock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170420.153953.2254487909608010855.davem@davemloft.net>
Date:   Thu, 20 Apr 2017 15:39:53 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     maloneykernel@...il.com
Cc:     netdev@...r.kernel.org, sowmini.varadhan@...cle.com,
        maloney@...gle.com
Subject: Re: [PATCH net] selftests/net: Fixes psock_fanout CBPF test case

From: Mike Maloney <maloneykernel@...il.com>
Date: Tue, 18 Apr 2017 11:14:16 -0400

> From: Mike Maloney <maloney@...gle.com>
> 
> 'psock_fanout' has been failing since commit 4d7b9dc1f36a9 ("tools:
> psock_lib: harden socket filter used by psock tests").  That commit
> changed the CBPF filter to examine the full ethernet frame, and was
> tested on 'psock_tpacket' which uses SOCK_RAW.  But 'psock_fanout' was
> also using this same CBPF in two places, for filtering and fanout, on a
> SOCK_DGRAM socket.
> 
> Change 'psock_fanout' to use SOCK_RAW so that the CBPF program used with
> SO_ATTACH_FILTER can examine the entire frame.  Create a new CBPF
> program for use with PACKET_FANOUT_DATA which ignores the header, as it
> cannot see the ethernet header.
> 
> Tested: Ran tools/testing/selftests/net/psock_{fanout,tpacket} 10 times,
> and they all passed.
> 
> Fixes: 4d7b9dc1f36a9 ("tools: psock_lib: harden socket filter used by psock tests")
> Signed-off-by: 'Mike Maloney <maloneykernel@...il.com>'

Applied, thanks.