netdev - Re: [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lgqva1v3.fsf@miraculix.mork.no>
Date:   Thu, 20 Apr 2017 11:02:08 +0200
From:   Bjørn Mork <bjorn@...k.no>
To:     Aleksander Morgado <aleksander@...ksander.es>
Cc:     Daniele Palmas <dnlplm@...il.com>,
        "netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201

Aleksander Morgado <aleksander@...ksander.es> writes:

> I'm just running --dms-get-operating-mode multiple times, and getting
> errors frequently:

Could you retry that with cdc-wdm debugging enabled (e.g.
"echo 'module cdc_wdm +fp' > /sys/kernel/debug/dynamic_debug/control")
and something like this:


diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
index 8fda45a45bd3..c0f25ace9fc6 100644
--- a/drivers/usb/class/cdc-wdm.c
+++ b/drivers/usb/class/cdc-wdm.c
@@ -211,6 +211,8 @@ static void wdm_in_callback(struct urb *urb)
 		}
 	}
 
+	dev_dbg(&desc->intf->dev, "rerr=%d, status=%d, length=%d, resp_count=%d\n", desc->rerr, status, length, desc->resp_count);
+
 	/*
 	 * Handling devices with the WDM_DRAIN_ON_OPEN flag set:
 	 * If desc->resp_count is unset, then the urb was submitted
@@ -516,6 +518,9 @@ static ssize_t wdm_read
 		return -ERESTARTSYS;
 
 	cntr = ACCESS_ONCE(desc->length);
+
+	dev_dbg(&desc->intf->dev, "rerr=%d, length=%d\n", desc->rerr, cntr);
+
 	if (cntr == 0) {
 		desc->read = 0;
 retry:



And/or a usbmon dump?  That would be.probably show us the sequence of
events leading to this problem.

Desperately trying to figure out some other way to solve the issue that
commit  833415a3e781 ("cdc-wdm: fix "out-of-sync" due to missing
notifications") was supposed to fix....



Bjørn