netdev - Re: [PATCH 2/2] sparc64: Add eBPF JIT.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170420.184934.719100622429060115.davem@davemloft.net>
Date:   Thu, 20 Apr 2017 18:49:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     daniel@...earbox.net
Cc:     sparclinux@...r.kernel.org, netdev@...r.kernel.org, ast@...nel.org
Subject: Re: [PATCH 2/2] sparc64: Add eBPF JIT.

From: Daniel Borkmann <daniel@...earbox.net>
Date: Wed, 19 Apr 2017 11:35:39 +0200

> On 04/18/2017 08:58 PM, David Miller wrote:
>> +	if (!prog || !prog->len)
>> +		return orig_prog;
> 
> This condition can be removed, see also 93a73d442d37
> ("bpf, x86/arm64: remove useless checks on prog"), since
> there's no way we could land here under such circumstance.

Ok.

>> +	bpf_flush_icache(ctx.image, ctx.image + image_size);
> 
> Since remaining parts were filled through jit_fill_hole(),
> it would be better / more correct to flush the whole buffer,
> see also the recent ppc64 commit 10528b9c45cf ("powerpc/bpf:
> Flush the entire JIT buffer") that fixed it for their jit.

Ok, I've made that change too, thanks!