netdev - Re: [PATCHv2 next] bonding: fix wq initialization for links created via netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170421.152913.1790106808332321956.davem@davemloft.net>
Date:   Fri, 21 Apr 2017 15:29:13 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mahesh@...dewar.net
Cc:     j.vosburgh@...il.com, andy@...yhouse.net, vfalico@...il.com,
        nikolay@...hat.com, edumazet@...gle.com, joe@....org,
        netdev@...r.kernel.org, maheshb@...gle.com
Subject: Re: [PATCHv2 next] bonding: fix wq initialization for links
 created via netlink

From: Mahesh Bandewar <mahesh@...dewar.net>
Date: Thu, 20 Apr 2017 12:49:24 -0700

> From: Mahesh Bandewar <maheshb@...gle.com>
> 
> Earlier patch 4493b81bea ("bonding: initialize work-queues during
> creation of bond") moved the work-queue initialization from bond_open()
> to bond_create(). However this caused the link those are created using
> netlink 'create bond option' (ip link add bondX type bond); create the
> new trunk without initializing work-queues. Prior to the above mentioned
> change, ndo_open was in both paths and things worked correctly. The
> consequence is visible in the report shared by Joe Stringer -
> 
> I've noticed that this patch breaks bonding within namespaces if
> you're not careful to perform device cleanup correctly.
> 
> Here's my repro script, you can run on any net-next with this patch
> and you'll start seeing some weird behaviour:
 ...
> Fixes: 4493b81bea ("bonding: initialize work-queues during creation of bond")
> Reported-by: Joe Stringer <joe@....org>
> Tested-by: Joe Stringer <joe@....org>
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>

Applied, thanks.