netdev - [RFC] change the default Kconfig value of mlx5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Apr 2017 21:45:00 +0200
From:   Ian Kumlien <ian.kumlien@...il.com>
To:     saeedm@...lanox.com,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: [RFC] change the default Kconfig value of mlx5_en

Hi,

For some reason I spend some hours, two days in a row, trying to debug
why a newer
kernel didn't work on our machines. It worked just fine with the older kernel...

And there was no network interfaces to see or try to figure out what
was going on with.

Playing with the infiniband tools all i could see was things like:
...
state: 1: DOWN
phys state: 3: Disabled
cat: /sys/class/infiniband/mlx5_0/ports/1/rate: Invalid argument
rate: unknown
link_layer: Ethernet
...

It turns out that the kernel was compiled with mlx5_en disabled, since
it's the default

Unless there is a really good reason not to, lets change the default
value to 'y' =)

I'm hoping that this will lead to others not experiencing the same
surreal journey of
trying to debug this ;)

----

The mellanox driver supports both ethernet and infiniband, but it
is located in the ethernet drivers - the ethernet support should
default to 'yes'.

Signed-off-by: Ian Kumlien <ian.kumlien@...il.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
index ddb4ca4ff930..206894f06dec 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
@@ -15,7 +15,7 @@ config MLX5_CORE_EN
  bool "Mellanox Technologies ConnectX-4 Ethernet support"
  depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
  imply PTP_1588_CLOCK
- default n
+ default y
  ---help---
   Ethernet support in Mellanox Technologies ConnectX-4 NIC.

-- 
2.12.2

View attachment "0001-Switch-mlx5_en-default-configiuration-value.patch" of type "text/x-patch" (1070 bytes)