netdev - Re: [PATCH v2] netpoll: Check for skb->queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170421.154554.219059312422333404.davem@davemloft.net>
Date:   Fri, 21 Apr 2017 15:45:54 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tushar.n.dave@...cle.com
Cc:     brouer@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org,
        sowmini.varadhan@...cle.com
Subject: Re: [PATCH v2] netpoll: Check for skb->queue_mapping

From: Tushar Dave <tushar.n.dave@...cle.com>
Date: Thu, 20 Apr 2017 15:57:31 -0700

> Reducing real_num_tx_queues needs to be in sync with skb queue_mapping
> otherwise skbs with queue_mapping greater than real_num_tx_queues
> can be sent to the underlying driver and can result in kernel panic.
> 
> One such event is running netconsole and enabling VF on the same
> device. Or running netconsole and changing number of tx queues via
> ethtool on same device.
 ...
> Signed-off-by: Tushar Dave <tushar.n.dave@...cle.com>
> ---
> v1->v2:
> - addressed comments from Eric Dumazet.

Applied and queued up for -stable, thanks!