netdev - Re: [PATCH net-next 3/3] net/tcp_fastopen: Remove mss check in tcp_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQymfM=HZUg_b3brU1iV5V4JLnDKNubLvtADj1j6Y3mxZwg@mail.gmail.com>
Date:   Thu, 20 Apr 2017 23:06:50 -0400
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Yuchung Cheng <ycheng@...gle.com>
Cc:     Wei Wang <weiwan@...gle.com>, netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 3/3] net/tcp_fastopen: Remove mss check in tcp_write_timeout()

On Thu, Apr 20, 2017 at 5:29 PM, Yuchung Cheng <ycheng@...gle.com> wrote:
> On Thu, Apr 20, 2017 at 2:45 PM, Wei Wang <weiwan@...gle.com> wrote:
>> From: Wei Wang <weiwan@...gle.com>
>>
>> Christoph Paasch from Apple found another firewall issue for TFO:
>> After successful 3WHS using TFO, server and client starts to exchange
>> data. Afterwards, a 10s idle time occurs on this connection. After that,
>> firewall starts to drop every packet on this connection.
>>
>> The fix for this issue is to extend existing firewall blackhole detection
>> logic in tcp_write_timeout() by removing the mss check.
>>
>> Signed-off-by: Wei Wang <weiwan@...gle.com>
> Acked-by: Yuchung Cheng <ycheng@...gle.com>

Acked-by: Neal Cardwell <ncardwell@...gle.com>

neal