netdev - Re: [PATCH net-next v2 1/5] nfp: make use of the DMA_ATTR_SKIP_CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170421173625.30774a5d@cakuba.lan>
Date:   Fri, 21 Apr 2017 17:36:25 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     netdev@...r.kernel.org
Cc:     oss-drivers@...ronome.com,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: Re: [PATCH net-next v2 1/5] nfp: make use of the
 DMA_ATTR_SKIP_CPU_SYNC attribute

On Fri, 21 Apr 2017 12:23:06 -0700, Jakub Kicinski wrote:
> DMA unmap may destroy changes CPU made to the buffer.  To make XDP
> run correctly on non-x86 platforms we should use the
> DMA_ATTR_SKIP_CPU_SYNC attribute.
> 
> Thanks to using the attribute we can now push the sync operation to the
> common code path from XDP handler.
> 
> A little bit of variable name reshuffling is required to bring the
> code back to readable state.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

I think I need to add the sync for device after XDP DROP as well.

Please drop this series, I'll send v3, sorry.