netdev - Re: compile issue in latest iproute2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Apr 2017 18:18:58 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jamal Hadi Salim <jhs@...atatu.com>,
        Stephen Hemminger <stephen@...workplumber.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: compile issue in latest iproute2

On 04/22/2017 05:00 PM, Daniel Borkmann wrote:
> On 04/22/2017 02:31 PM, Jamal Hadi Salim wrote:
>>
>> I dont think is a kernel uapi - but it was failing compiling
>> when HAVE_ELF is false.
>> -----
>> jhs@...-UX:~/git-trees/others/iproute-with-ck$ git diff include/bpf_util.h
>> diff --git a/include/bpf_util.h b/include/bpf_util.h
>> index 5361dab..edca339 100644
>> --- a/include/bpf_util.h
>> +++ b/include/bpf_util.h
>> @@ -266,7 +266,7 @@ int bpf_send_map_fds(const char *path, const char *obj);
>>   int bpf_recv_map_fds(const char *path, int *fds, struct bpf_map_aux *aux,
>>                       unsigned int entries);
>>   #else
>> -static inline int bpf_send_map_fds(const char *path, const char *obj)
>> +inline int bpf_send_map_fds(const char *path, const char *obj)
>>   {
>>          return 0;
>>   }
>> -----
>>
>> Let me know if you want a formal patch or feel free to take it.
>
> Will resolve it and send a patch later today, thanks!

Hmm, I'm on latest f443565f8df6 ("ip vrf: Add command name next to
pid") commit in master branch. Compiles fine for me with and without
ELF support. I verified that there's no HAVE_ELF defined and I'm
not seeing an error.

Without ELF support:

# ./configure
TC schedulers
  ATM	no

libc has setns: yes
SELinux support: yes
ELF support: no
libmnl support: yes
Berkeley DB: yes

docs: latex: yes
  pdflatex: yes
  sgml2latex: no
  WARNING: no LaTeX files can be build from SGML files
  sgml2html: no
  WARNING: no HTML docs can be built from SGML

# make > /dev/null
ssfilter.y: conflicts: 35 shift/reduce
#

With ELF support:

# ./configure
TC schedulers
  ATM	no

libc has setns: yes
SELinux support: yes
ELF support: yes
libmnl support: yes
Berkeley DB: yes

docs: latex: yes
  pdflatex: yes
  sgml2latex: no
  WARNING: no LaTeX files can be build from SGML files
  sgml2html: no
  WARNING: no HTML docs can be built from SGML

# make > /dev/null
ssfilter.y: conflicts: 35 shift/reduce
#

Anything I'm missing?