netdev - Re: [PATCH net] udp: disable inner UDP checksum offloads in IPsec case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170424.134913.859328581317183203.davem@davemloft.net>
Date:   Mon, 24 Apr 2017 13:49:13 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     aatteka@....org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] udp: disable inner UDP checksum offloads in IPsec
 case

From: Ansis Atteka <aatteka@....org>
Date: Fri, 21 Apr 2017 15:23:05 -0700

> Otherwise, UDP checksum offloads could corrupt ESP packets by attempting
> to calculate UDP checksum when this inner UDP packet is already protected
> by IPsec.
> 
> One way to reproduce this bug is to have a VM with virtio_net driver (UFO
> set to ON in the guest VM); and then encapsulate all guest's Ethernet
> frames in Geneve; and then further encrypt Geneve with IPsec.  In this
> case following symptoms are observed:
> 1. If using ixgbe NIC, then it will complain with following error message:
>    ixgbe 0000:01:00.1: partial checksum but l4 proto=32!
> 2. Receiving IPsec stack will drop all the corrupted ESP packets and
>    increase XfrmInStateProtoError counter in /proc/net/xfrm_stat.
> 3. iperf UDP test from the VM with packet sizes above MTU will not work at
>    all.
> 4. iperf TCP test from the VM will get ridiculously low performance because.
> 
> Signed-off-by: Ansis Atteka <aatteka@....org>
> Co-authored-by: Steffen Klassert <steffen.klassert@...unet.com>

Applied, thanks.